Remove deprecated [Serializable] attribute from TranslatableXmlModel #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [Serializable] attribute is no longer needed as binary serialization has been removed in modern .NET versions. This class uses XmlSerializer which doesn't require the [Serializable] attribute. All tests pass after this change. Co-authored-by: Soar360 <15421284+Soar360@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix errors in unit test project
Remove deprecated [Serializable] attribute from TranslatableXmlModel
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary serialization support was removed in modern .NET. The
[Serializable]attribute onTranslatableXmlModel<T>serves no purpose since the class usesXmlSerializer, which doesn't require it.Changes
[Serializable]attribute fromTranslatableXmlModel<T>insrc/LuYao.Common/Xml/TranslatableXmlModel.csThe class continues to work identically with
XmlSerializer, which uses reflection and XML-specific attributes ([XmlElement],[XmlAttribute], etc.) rather than the binary serialization marker attribute.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.